On 06.05.21 16:41, Julien Pivotto wrote: > On 06 May 14:01, Bjoern Rabenstein wrote: > > Initially, I intuitively thought we should do what Julien has now > > proposed, too. However, in the course of the discussion, I then > > convinced myself that Tristan's approach makes more sense. > > > > So maybe we all have to go through these stages. (o: > > > I am splitting the end user experience from the implementation. > > We could pass the labelname + "\0" + formatting to the aggr function, > which would simulate Tristan's approach without being complex for the > user.
I think Tristan's approach is easier for the user. A separate formatting string suggests to be, well, a formatting string. But we only want a number and a single character. Plus, it's pretty much a power-user feature, so an additional optional parameter is a bit too prominent for my taste. -- Björn Rabenstein [PGP-ID] 0x851C3DA17D748D03 [email] [email protected] -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20210506145348.GN7498%40jahnn.
