Hi,

I would lik to propose making retrier configurable in slack.Notifier 
<https://github.com/prometheus/alertmanager/blob/d6e758ad3792ce6a78032f6d2ae706f367422e35/notify/slack/slack.go#L41>
 
by adding it as a parameter to slack.New 
<https://github.com/prometheus/alertmanager/blob/d6e758ad3792ce6a78032f6d2ae706f367422e35/notify/slack/slack.go#L45>.
 
This would allow providing a Retrier.CustomDetailsFunc 
<https://github.com/prometheus/alertmanager/blob/d6e758ad3792ce6a78032f6d2ae706f367422e35/notify/util.go#L160>
 
externally.

We have a custom go admin application for alert rules and notifications 
that allows configuring alertmanager to our users and we have a feature of 
sending test notifications. We use alertamanger as a library. When the user 
provides an invalid slack url e.g. https://slack.com/whatever slack returns 
a huge 404 page that looks bad in our ui's error message. Right now we need 
some regexp magic to filter out these errors, and it would be much more 
elegant if we could provide our own CustomDetailsFunc implementation.

This idea is related only to the slack.New function when used as a library, 
it does not affect alertmanager configuration as a standalone application. 
Please let me know if it makes sense, and I'm happy to provide patch.

Best,
Peter

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/f12f9e4d-95dd-4909-9b3e-2f992b5b9c9dn%40googlegroups.com.

Reply via email to