Seems fine to me. Two requirements that come to mind: * We need a "machine" level executor, for some builds that don't work well in Docker. * We need a stackable containers/compose type for some integration tests, for example MySQL and Postgres exporters.
I have not looked into how those work with GitHub actions. On Thu, Jun 16, 2022, 10:45 AM Julien Pivotto <[email protected]> wrote: > Hello, > > Based on a request from CNCF, I'd like to move from CircleCI to Github > Action. > > We are already using GitHub actions today, for linting and fuzzing. > > Compared to what we are using in CircleCI, it looks like GitHub action > runners are comparable in size, with slightly more ram. > > Pros' of the move: > - Remove a CI system > - Better integration with Github (access to logs, etc) > - It seems better for CNCF itself > > Con's of the move: > - Threading (e.g. parallel builds) will be a bit more itchy at the > moment but will be doable. > > I plan to do the work in the coming weeks, unless we don't have lazy > consensus. > > Regards, > > -- > Julien Pivotto > @roidelapluie > > -- > You received this message because you are subscribed to the Google Groups > "Prometheus Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/prometheus-developers/YqrtnRGCHWT5f1w1%40nixos > . > -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CABbyFmpDTBvVRzc5uYsDVqgmHt97XzurXnoZJJaqOzar8Hp1KA%40mail.gmail.com.
