So it would be possible to make a PR to make that value/Executorservice configurable?
Milan po 23. 3. 2020 v 13:40 odesÃlatel Brian Brazil < [email protected]> napsal: > On Mon, 23 Mar 2020 at 12:38, Milano Nicolum <[email protected]> wrote: > >> Hi, >> at the moment I use prometheus-java-client 0.8.1 with out of the box >> HTTPServer to expose metrics on my K8S pods and Prometheus discovery to >> scrape them. >> I just wonder if there is any particular reason to use fixedThreadPool of >> size 5 as default. - >> https://github.com/prometheus/client_java/blob/master/simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java#L167 >> > > It's a hardcoded value, and it seems unlikely that you'd have 5 scrapes at > once so it's a conservative choice. > > Brian > > >> >> >> As the metrics endpoint is usually accessed by prometheus scrape only I >> feel as 5 threads are quite a luxury to have on every pod. I wonder if >> there is any response time based reasoning behind the pool size or some >> situation I still have to experience. >> >> https://github.com/prometheus/client_java/blob/master/simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java#L167 >> >> While I guess the default HTTPServer could be replace by different >> implementation I just want to know what setup is the most lightweight and >> reliable at the same time. >> Thanks, >> Milan. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Prometheus Users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/prometheus-users/9e57f6c6-51ad-49c0-8c9a-b3f58945143a%40googlegroups.com >> <https://groups.google.com/d/msgid/prometheus-users/9e57f6c6-51ad-49c0-8c9a-b3f58945143a%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > > > -- > Brian Brazil > www.robustperception.io > -- You received this message because you are subscribed to the Google Groups "Prometheus Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-users/CAEDfKrrat9ZzMgTSskkU9bK335w2F6X8VjN1E6w_U3oarCLKvA%40mail.gmail.com.
