On Thu, Jul 2, 2020 at 9:57 PM Ranganath Sunku <[email protected]> wrote:
> Thanks for your fast responses. > > Sounds like if the dependent library is written in Go to retrieve system > metrics, node_exporter would be open to accepting such a collector. > Is it right to understand that as long as we dont use CGo for 'C' based > libraries, but use Go based dependencies we are good? > Yup, that's basically it. We want to stick with pure go libraries. (like we do with https://github.com/prometheus/procfs) > > Thanks > Sunku > > On Wednesday, July 1, 2020 at 5:13:46 AM UTC-7, Ben Kochie wrote: >> >> We did some work previously to eliminate use of CGO in the node_exporter >> on Linux. CGO has a long history of being a bit fragile. We do use it for >> Non-Linux for gathering syscalls from OS functions that don't have >> Go-native implementations. >> >> Normally I wouldn't object to adding RedFish to the node_exporter, but >> since it's missing a Go-native library implementation makes it not a good >> fit for our goals. >> >> On Wed, Jul 1, 2020 at 9:28 AM Brian Candler <[email protected]> wrote: >> >>> It sounds to me like this should be a separate exporter, like >>> ipmi_exporter - especially since libredfish is a C library (according to >>> Google anyway) >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Prometheus Users" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/prometheus-users/4afce4b3-425e-4962-98c4-128b6b2e1548o%40googlegroups.com >>> <https://groups.google.com/d/msgid/prometheus-users/4afce4b3-425e-4962-98c4-128b6b2e1548o%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to the Google Groups > "Prometheus Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/prometheus-users/cd9d7b6f-237a-413b-a370-519115470546o%40googlegroups.com > <https://groups.google.com/d/msgid/prometheus-users/cd9d7b6f-237a-413b-a370-519115470546o%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Prometheus Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-users/CABbyFmrGYhJ33n86Z%3D3FJWHwSB-sCPX1OctYmCa%3DoEQmknQdeQ%40mail.gmail.com.
