Hi beorn7, Sorry for delayed response. I choose MetricsQL as the parser for simplicity, as it require little dependencies. it seems that PR 7779 is a non-trivial one, I have on idea if it's easy to merge my code to it although format logic is similar.
Maybe I need more time to dig into this. Could anyone guide me to finish 7779? On Monday, October 11, 2021 at 11:48:48 PM UTC+8 [email protected] wrote: > On 28.09.21 19:47, Bjoern Rabenstein wrote: > > On 18.09.21 23:42, Jiacai Liu wrote: > > > > > > Have trouble in reading PromQL written by your colleagues or SRE team? > > > > > > promql-prettier to the rescue! > > > > > > - https://github.com/jiacai2050/promql-prettier > > > > > > Any issues or feedbacks are welcomed. > > > > That looks pretty neat. I'll try it out. > > > > Did you collaborate with Harkishen Singh, whose GSoC project was > > tackling the same problem and who wrote the design doc? Or did you all > > of this from scratch? > > > > Any reason why you used the MetricsQL parser rather than the PromQL > > parser? Both languages are slightly different, and new features in > > PromQL won't necessarily make it to MetricsQL or might be delayed... > > > > It would be cool to have this integrated in promtool as originally > > planned. Another reason to use the Prometheus codebase... > > I haven't seen any reply to the above, but by now, I can provide a bit > more context: > > There was already an effort to implement the original design > doc. Sadly, the PR became stale, but it would be cool to revive it, > see https://github.com/prometheus/prometheus/pull/7779 . > > The problem with jiacai2050/promql-prettier is that it is actually not > a PromQL prettier but a MetricsQL prettier. Jiacai, if you do not have > plans to make it compliant with PromQL, you should consider renaming > it to avoid confusing your users. Note that PromQL is well defined. It > is also trademarked by the Linux Foundation. Check out > https://www.linuxfoundation.org/trademark-usage/ for implications. > > Thanks for your understanding. > -- > Björn Rabenstein > [PGP-ID] 0x851C3DA17D748D03 > [email] [email protected] > -- You received this message because you are subscribed to the Google Groups "Prometheus Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-users/13f37bd8-577a-47a5-919c-964b7ff9bb61n%40googlegroups.com.
