Hi Tejaswini,

I'm not familiar with the exact metrics that Envoy exposes, but it just
sounds like they are just not really following the conventions from
https://prometheus.io/docs/practices/naming/ correctly for all metrics and
not outputting HELP string lines. Now since those are only conventions and
optional features, this should not create a problem other than you having a
bit of a harder time interpreting and dealing with those metrics.
Prometheus-compatible vendors should be able to handle those just
fine, otherwise they are not compatible.

Regards,
Julius

On Tue, Jul 12, 2022 at 2:18 PM tejaswini vadlamudi <[email protected]>
wrote:

> If we run promtool on Envoy proxy,  we get the below lint errors:
>
>    1. no help text
>    2. should have "_total" suffix
>    3. use base unit "seconds" instead of "days"
>    4. metric names should not contain abbreviated units
>
> Not sure if these errors are terrible and have potential issues when
> Prometheus or any other Prometheus-compatible vendor is used as a metrics
> collector in the long run.
>
> What do you guys suggest for such a kind of instrumentation pattern?
>
> /Teja
>
> --
> You received this message because you are subscribed to the Google Groups
> "Prometheus Users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/prometheus-users/4ddd2372-483d-4896-8a19-0a96635fe8e3n%40googlegroups.com
> <https://groups.google.com/d/msgid/prometheus-users/4ddd2372-483d-4896-8a19-0a96635fe8e3n%40googlegroups.com?utm_medium=email&utm_source=footer>
> .
>


-- 
Julius Volz
PromLabs - promlabs.com

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-users/CAObpH5xBC%2BZpgCo7C8-m%2BF62U0DUJjvah54X6FkJ2FtjAaa_fg%40mail.gmail.com.

Reply via email to