Hi Paul, Thanks for the patch, and sorry it's taken a while to get to review it.
As it stands, the patch changes the current behaviour in a negative way. I guess your intention is to allow the target directory to be not owned by the prosody user (I'm curious why). The current code checks that the directory is owned by prosody, writable by prosody, and also that it is *not* writable by any other user. The current proposed patch removes the first and last checks, and just ensures it is writable by the current user. This also makes the warning message incorrect. And for the larger picture, there are some related issues: - https://issues.prosody.im/1217 - https://issues.prosody.im/999 We have been discussing various solutions to make the feature more robust and less surprising (including removing some features if needed). I'm curious to hear your thoughts, and exactly how you're using it that makes the current code inadequate. That will help with figuring out the best solution. Regards, Matthew On Sat, 18 Jan 2020 at 19:49, Paul Tiedtke <[email protected]> wrote: > > Hey guys, > > > > I already submitted this change a few month ago but my thread never appeared. > MattJ couldn’t find it as well – so we decided to try it again. > > > > My patch will improve the permission checks to check for all user and > directory permissions. And will really solve the following issue. > > https://issues.prosody.im/1075 > > > > Best, > > Paul (sapkra) > > -- You received this message because you are subscribed to the Google Groups "prosody-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prosody-dev/CAJt9-x7P16xHdL88zQT%3D9KsfzzVLX9Rpru9sLaLnqvbjhGZ8%2BQ%40mail.gmail.com.
