On Wed, Jun 10, 2020 at 9:13 AM Kim Alvefur <[email protected]> wrote: > > Hi > > On Mon Jun 1, 2020 at 4:44 PM CEST, Boris Grozev wrote: > > Hello everyone, > > > > We have a use-case where we don't know the IP addresses of our HTTP > > proxies in advance, so we want to configure an entire network in > > trusted_proxies. I opted to implement it with additional syntax in the > > trusted_proxies list in order to keep the configuration under the > > existing key, while avoiding a change in semantics for existing > > configurations (the "." in IP literals becomes a wildcard character in > > a regexp). > > > > Ideally this would support CIDR notation (so we can express e.g. > > 172.16/12), but that seemed much more complicated and not necessary > > for our case. > > CIDR notation is supported by util.ip, which unfortunately is missing > documentation. Example use can be found in mod_register_limits, added in > this change: https://hg.prosody.im/0.11/rev/4796fdcb7146
That's much better, thanks for the pointer! The spec file is also useful as a doc. > > > Let me know if there's any changes you'd like me to make in order for > > the patch to be accepted. > > Normalize the whitespace to tabs please. Fixed, attached the new patch. Regards, Boris -- You received this message because you are subscribed to the Google Groups "prosody-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prosody-dev/CAFCpYuwPC4qt58AU7EmTR2cTiDY0ghoNtURmLQRf4dr%3DjbtpdA%40mail.gmail.com.
mod-http-support-cidr.patch
Description: Binary data
