Code looks good to me (minus two typos that I'll fix before submitting). Which just leaves the legal annoyance... Have you signed the contributor license agreement? http://code.google.com/legal/individual-cla-v1.0.html http://code.google.com/legal/corporate-cla-v1.0.html
On Thu, Sep 25, 2008 at 7:40 PM, Kenton Varda <[EMAIL PROTECTED]> wrote: > Apparently codereview.appspot.com allows over-zealous browser caching. I > had to refresh. I see it now. Will review tonight or tomorrow. > > > On Thu, Sep 25, 2008 at 5:37 PM, Travis <[EMAIL PROTECTED]> wrote: > >> >> On Sep 25, 2008, at 6:51 PM, Kenton Varda wrote: >> >> I still only see the first patch set. >>> >> >> >> You don't see this? >> "Patch Set 2 : Same changes, but might fix problem where side-by-side >> diffs didn't work" >> >> I'm looking at http://codereview.appspot.com/6051 and I see it. And if I >> look at the side-by-side diffs, they look fine (I did see the error that you >> saw with my "Patch Set 1"). >> >> > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/protobuf?hl=en -~----------~----~----~----~------~----~------~--~---
