Fix submitted.  Sorry for the delay and false alarm.

On Mon, Dec 1, 2008 at 6:32 PM, Kenton Varda <[EMAIL PROTECTED]> wrote:

> Sorry, I'm dumb and made the change in the wrong place.  :)
>
>
> On Mon, Dec 1, 2008 at 6:29 PM, Kenton Varda <[EMAIL PROTECTED]> wrote:
>
>> Unfortunately, the change doesn't work:
>> Traceback (most recent call last):
>>   File "setup.py", line 131, in ?
>>     long_description =
>>   File "/usr/lib/python2.4/distutils/core.py", line 149, in setup
>>     dist.run_commands()
>>   File "/usr/lib/python2.4/distutils/dist.py", line 946, in run_commands
>>     self.run_command(cmd)
>>   File "/usr/lib/python2.4/distutils/dist.py", line 966, in run_command
>>     cmd_obj.run()
>>   File
>> "/usr/lib/python2.4/site-packages/setuptools-0.6c8-py2.4.egg/setuptools/command/test.py",
>> line 121, in run
>>     self.with_project_on_sys_path(self.run_tests)
>>   File
>> "/usr/lib/python2.4/site-packages/setuptools-0.6c8-py2.4.egg/setuptools/command/test.py",
>> line 101, in with_project_on_sys_path
>>     func()
>>   File
>> "/usr/lib/python2.4/site-packages/setuptools-0.6c8-py2.4.egg/setuptools/command/test.py",
>> line 130, in run_tests
>>     testLoader = loader_class()
>>   File "/usr/lib/python2.4/unittest.py", line 758, in __init__
>>     self.parseArgs(argv)
>>   File "/usr/lib/python2.4/unittest.py", line 785, in parseArgs
>>     self.createTests()
>>   File "/usr/lib/python2.4/unittest.py", line 791, in createTests
>>     self.module)
>>   File "/usr/lib/python2.4/unittest.py", line 556, in loadTestsFromNames
>>      suites = [self.loadTestsFromName(name, module) for name in names]
>>   File "/usr/lib/python2.4/unittest.py", line 544, in loadTestsFromName
>>     test = obj()
>>   File "/localhome/kenton/src/protobuf-svn5/protobuf/python/setup.py",
>> line 62, in MakeTestSuite
>>      import google.protobuf.internal.generator_test     as generator_test
>>   File
>> "/localhome/kenton/src/protobuf-svn5/protobuf/python/google/protobuf/internal/generator_test.py",
>> line 45, in ?
>>      from google.protobuf import unittest_mset_pb2
>>   File
>> "/localhome/kenton/src/protobuf-svn5/protobuf/python/google/protobuf/unittest_mset_pb2.py",
>> line 9, in ?
>>     from google.protobuf import descriptor_pb2
>>   File
>> "/localhome/kenton/src/protobuf-svn5/protobuf/python/google/protobuf/descriptor_pb2.py",
>> line 879, in ?
>>     class FileDescriptorSet(message.Message):
>>   File
>> "/localhome/kenton/src/protobuf-svn5/protobuf/python/google/protobuf/reflection.py",
>> line 121, in __new__
>>     return superclass.__new__(name, bases, dictionary)
>> TypeError: Error when calling the metaclass bases
>>     type.__new__(X): X is not a type object (str)
>>
>> On Mon, Dec 1, 2008 at 6:23 PM, Petar Petrov <[EMAIL PROTECTED]>wrote:
>>
>>>
>>> On Fri, Nov 7, 2008 at 10:04 AM, Kenton Varda <[EMAIL PROTECTED]> wrote:
>>>
>>>> I don't know Python very well.  Petar, can you verify this is correct?
>>>>  (I tried it and the tests still pass.)
>>>
>>>
>>> Yes, the change looks good.
>>> Sorry, I missed this thread.
>>>
>>>
>>>>
>>>>
>>>> On Thu, Nov 6, 2008 at 11:43 PM, Pavel Shramov <[EMAIL PROTECTED]>wrote:
>>>>
>>>>>
>>>>> In 2.4, 2.5 and 2.6 superclass constructor call don't need self as
>>>>> first arg
>>>>> but 2.6 raises error if it's given.
>>>>> ---
>>>>>  python/google/protobuf/reflection.py |    2 +-
>>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>>>
>>>>> diff --git a/python/google/protobuf/reflection.py
>>>>> b/python/google/protobuf/reflection.py
>>>>> index d80942e..25dd04b 100755
>>>>> --- a/python/google/protobuf/reflection.py
>>>>> +++ b/python/google/protobuf/reflection.py
>>>>> @@ -152,7 +152,7 @@ class GeneratedProtocolMessageType(type):
>>>>>     _AddMessageMethods(descriptor, cls)
>>>>>     _AddPrivateHelperMethods(cls)
>>>>>     superclass = super(GeneratedProtocolMessageType, cls)
>>>>> -    superclass.__init__(cls, name, bases, dictionary)
>>>>> +    superclass.__init__(name, bases, dictionary)
>>>>>
>>>>>
>>>>>  # Stateless helpers for GeneratedProtocolMessageType below.
>>>>> --
>>>>> 1.5.6.5
>>>>>
>>>>>
>>>>> >>>>>
>>>>>
>>>>
>>>
>>
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To post to this group, send email to protobuf@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to