Sorry about the delay. Mostly looks good, just a few nits
File google/protobuf/compiler/cpp/ (right):
Line 401:
Indent() for prettier generated code?
File google/protobuf/compiler/cpp/ (right):
Line 608: "delete $classname$::default_instance_;\n"
Set these to NULL for consistency with other parts of the library?
File google/protobuf/ (right):
Line 84: delete registry_;
registry_ = NULL;?
File google/protobuf/stubs/ (right):
Line 323: // We don't need to lock shutdown_fucntions_mutex because it's
up to the

You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to