Sorry about the delay. Mostly looks good, just a few nits

http://codereview.appspot.com/53053/diff/1/5
File google/protobuf/compiler/cpp/cpp_file.cc (right):

http://codereview.appspot.com/53053/diff/1/5#newcode401
Line 401:
Indent() for prettier generated code?

http://codereview.appspot.com/53053/diff/1/6
File google/protobuf/compiler/cpp/cpp_message.cc (right):

http://codereview.appspot.com/53053/diff/1/6#newcode608
Line 608: "delete $classname$::default_instance_;\n"
Set these to NULL for consistency with other parts of the library?

http://codereview.appspot.com/53053/diff/1/13
File google/protobuf/extension_set.cc (right):

http://codereview.appspot.com/53053/diff/1/13#newcode84
Line 84: delete registry_;
registry_ = NULL;?

http://codereview.appspot.com/53053/diff/1/9
File google/protobuf/stubs/common.cc (right):

http://codereview.appspot.com/53053/diff/1/9#newcode323
Line 323: // We don't need to lock shutdown_fucntions_mutex because it's
up to the
s/fucntions/functions/

http://codereview.appspot.com/53053

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To post to this group, send email to protobuf@googlegroups.com
To unsubscribe from this group, send email to 
protobuf+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to