On Mon, Jan 5, 2009 at 12:45 PM, Kenton Varda <ken...@google.com> wrote:

> On Sat, Jan 3, 2009 at 7:32 PM, Dave Wolfe <dwolfe5...@hotmail.com> wrote:
>
>>
>> FYI, it looks like a few new functions are missing __declspec()
>> decorators.  I had to apply the trivial patch below in order to
>> build a DLL version of protobuf under Windows.  (This applies to
>> both 2.0.3 and the current trunk...)
>
>
> Ouch, I guess I should explicitly test compiling DLLs before releasing.
>  Strange, though, because I have a script which is supposed to add the
> export decls for me.  Anyway, I'll look into this; thanks.
>

FYI:  Should be fixed in 2.1.0.


>
>
>>
>>
>> ----------
>>
>> Index: src/google/protobuf/repeated_field.h
>> ===================================================================
>> --- src/google/protobuf/repeated_field.h        (revision 90)
>> +++ src/google/protobuf/repeated_field.h        (working copy)
>> @@ -93,7 +93,7 @@
>>  };
>>
>>  // We need this (from generated_message_reflection.cc).
>> -int StringSpaceUsedExcludingSelf(const string& str);
>> +LIBPROTOBUF_EXPORT int StringSpaceUsedExcludingSelf(const string&
>> str);
>>
>>  }  // namespace internal
>>
>> Index: src/google/protobuf/stubs/common.h
>> ===================================================================
>> --- src/google/protobuf/stubs/common.h  (revision 90)
>> +++ src/google/protobuf/stubs/common.h  (working copy)
>> @@ -1075,7 +1075,7 @@
>>
>>  // Checks if the buffer contains structurally-valid UTF-8.
>> Implemented in
>>  // structurally_valid.cc.
>> -bool IsStructurallyValidUTF8(const char* buf, int len);
>> +LIBPROTOBUF_EXPORT bool IsStructurallyValidUTF8(const char* buf, int
>> len);
>>
>>  }  // namespace internal
>>
>> Index: src/google/protobuf/generated_message_reflection.h
>> ===================================================================
>> --- src/google/protobuf/generated_message_reflection.h  (revision 90)
>> +++ src/google/protobuf/generated_message_reflection.h  (working copy)
>> @@ -383,7 +383,7 @@
>>  // Compute the space used by a string, not including sizeof(string)
>> itself.
>>  // This is slightly complicated because small strings store their
>> data within
>>  // the string object but large strings do not.
>> -int StringSpaceUsedExcludingSelf(const string& str);
>> +LIBPROTOBUF_EXPORT int StringSpaceUsedExcludingSelf(const string&
>> str);
>>
>>
>>  }  // namespace internal
>>
>> >>
>>
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To post to this group, send email to protobuf@googlegroups.com
To unsubscribe from this group, send email to 
protobuf+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to