Good points. I wasn't a big fan of this change in the first place but apparently it was a big performance win on Android (which does not have a very advanced garbage collector at the moment). I guess we should make it optional, off-by-default. I'll make that change today and try to get another release candidate out.
2009/8/7 Holger Hoffstätte <[email protected]> > > Kenton Varda wrote: > > What kind of issues? > > Unless the ThreadLocals are explicitly cleared, the classloader can not be > unloaded/GCed and jars redeployed. The retained memory is not so much an > issue for protobuf, but other people have not been so lucky and ended up > with leaks of many megabytes of retained references per TL * the number of > threads that have the TL. > > > http://cs.oswego.edu/pipermail/concurrency-interest/2007-October/004435.html > http://crazybob.org/2006/07/hard-core-java-threadlocal.html > > TLs are great in theory, but in practice only work well for call chains > that can be properly coupled to their client lifecycles. > > -h > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/protobuf?hl=en -~----------~----~----~----~------~----~------~--~---
