(Is it just the gzip/zlib tests that are broken?  Nothing else in the
library should depend on the zlib stuff.)

On Sat, Aug 22, 2009 at 11:13 AM, Kenton Varda <ken...@google.com> wrote:

> Run configure --without-zlib to disable zlib support.  Alternatively, fix
> it and send me a patch.  :)
>
>
> On Fri, Aug 21, 2009 at 8:44 PM, Oliver Jowett <oliver.jow...@gmail.com>wrote:
>
>>
>> Oliver Jowett wrote:
>>
>> > The tests start failing here:
>> >
>> >> [----------] 14 tests from IoTest
>> >> [ RUN      ] IoTest.ArrayIo
>> >> [       OK ] IoTest.ArrayIo (4 ms)
>> >> [ RUN      ] IoTest.GzipIo
>> >> google/protobuf/io/zero_copy_stream_unittest.cc:194: Failure
>> >> Value of: WriteToOutput(output, str.c_str(), str.size())
>> >>   Actual: false
>> >> Expected: true
>> >> google/protobuf/io/zero_copy_stream_unittest.cc:194: Failure
>> >> Value of: WriteToOutput(output, str.c_str(), str.size())
>> >>   Actual: false
>> >> Expected: true
>> >> google/protobuf/io/zero_copy_stream_unittest.cc:194: Failure
>> >> Value of: WriteToOutput(output, str.c_str(), str.size())
>> >>   Actual: false
>> >> Expected: true
>> >
>> > and it all goes downhill from there.
>> >
>> > zlib is the system-installed /usr/lib/libz.so, which appears to be zlib
>> > 1.1.4.
>>
>> I added some tracing to gzip_stream.cc and the problem appears to be
>> that deflateInit2() is returning Z_STREAM_ERROR.
>>
>> Looking at the headers for zlib 1.1.4 it appears that older versions
>> don't support the gzip wrapper encoding bits being passed as part of
>> windowBits. The zlib changelog says that feature was only introduced in
>> 1.2.0.4
>>
>> Perhaps protobuf could check for (defined(ZLIB_VERNUM) && ZLIB_VERNUM >=
>> 0x1204) or similar before using the magic windowBits feature?
>>
>> -O
>>
>> >>
>>
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To post to this group, send email to protobuf@googlegroups.com
To unsubscribe from this group, send email to 
protobuf+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to