Revision 325 is equivalent to your patch, but I decided to arrange it a little differently. Thanks! Sorry for the long delay.
On Wed, Mar 24, 2010 at 11:38 AM, Nathan McDaniel <[email protected]>wrote: > Hi Kenton, > > The attached patch patches two files: > - coded_stream.h: disables "cast to smaller types" runtime checks in that > file, for Visual C++ >= 2003. This was the "least invasive" fix. I can > change it if you prefer. > - common.h: sets the __BYTE_ORDER to __LITTLE_ENDIAN for MSVC, which > enables the "copy full byte" optimizations (e.g. in coded_stream.h line > 744). > > > Nathan > > > > On Tue, Mar 23, 2010 at 5:00 PM, Kenton Varda <[email protected]> wrote: > >> The loss of data is intentional. I've never seen MSVC or any other >> compiler complain about this before. Feel free to send a patch adding the >> bit masks it asks for. >> >> -- > You received this message because you are subscribed to the Google Groups > "Protocol Buffers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<protobuf%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/protobuf?hl=en. > -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
