Comment #20 on issue 83 by [email protected]: protobuf does not compile cleanly in 64-bit mode in Visual Studio 2008
http://code.google.com/p/protobuf/issues/detail?id=83

This is getting really annoying for me. I'm willing to start providing patches, but I'd like to discuss before I spend a lot of time. The first thing I noticed is that

WireFormat::VerifyUTF8String(const char* data, int size, WireFormat::Operation op)

is always used on std::string. I get tons of warnings in the pb.cc files about the std::string::size_type and that second argument not matching in size. I'd suggest changing that to

WireFormat::VerifyUTF8String(const std::string& data, WireFormat::Operation op)

This requires a change to the built-in pb.cc files and cpp generator.


--
You received this message because you are subscribed to the Google Groups "Protocol 
Buffers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en.

Reply via email to