Comment #2 on issue 367 by [email protected]: MessageLite::ParseFromCodedStream: Should check ConsumedEntireMessage()
http://code.google.com/p/protobuf/issues/detail?id=367
Okay, I guess that makes sense, although this means that ParseFromCodedStream() behaves differently from the rest of the ParseFrom* member functions. Would you accept a patch to update the documentation for CodedInputStream::ConsumedEntireMessage() to add the fact that it should be called after ParseFromCodedStream() as well as MergeFromCodedStream()?
I must admit: I no longer remember the circumstances where this method returns false, but since the docs say it should be called after MergeFromCodedStream(), and ParseFromCodedStream() just calls MergeFromCodedStream(), it seems like this documentation update would help avoid "buggy" code that omits this check.
-- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
