Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 443 by ms2...@gmail.com: Fix warnings (-Wsign-compare and
-pedantic)
http://code.google.com/p/protobuf/issues/detail?id=443
When building protobuf within the Mozilla build system (which turns on
about as many warnings as possible) with GCC 4.6, a number of build
warnings are printed. The attached patch fixes the following ones:
google/protobuf/wire_format_lite.h:94:34 [-pedantic] comma at end of
enumerator list
google/protobuf/wire_format_lite.h:117:29 [-pedantic] comma at end of
enumerator list
google/protobuf/wire_format_lite.h:132:29 [-pedantic] comma at end of
enumerator list
google/protobuf/stubs/common.cc:221:2 [-pedantic] extra ‘;’
google/protobuf/stubs/common.cc:227:2 [-pedantic] extra ‘;’
google/protobuf/stubs/common.cc:355:58 [-Wsign-compare] comparison between
signed and unsigned integer expressions
google/protobuf/io/zero_copy_stream_impl_lite.cc:157:36 [-Wsign-compare]
comparison between signed and unsigned integer expressions
google/protobuf/io/coded_stream.cc:260:36 [-Wsign-compare] comparison
between signed and unsigned integer expressions
google/protobuf/io/coded_stream.cc:277:36 [-Wsign-compare] comparison
between signed and unsigned integer expressions
google/protobuf/io/coded_stream.cc:597:47 [-Wsign-compare] comparison
between signed and unsigned integer expressions
google/protobuf/io/coded_stream.cc:612:47 [-Wsign-compare] comparison
between signed and unsigned integer expressions
(Line numbers are probably a bit off; they're based on protobuf-2.4.1.)
Attachments:
proto 3.6 KB
--
You received this message because you are subscribed to the Google Groups "Protocol
Buffers" group.
To post to this group, send email to protobuf@googlegroups.com.
To unsubscribe from this group, send email to
protobuf+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/protobuf?hl=en.