Status: New
Owner: [email protected]
Labels: Type-Defect Priority-Medium

New issue 462 by [email protected]: r475 is incorrect
http://code.google.com/p/protobuf/issues/detail?id=462

r475 did:

Modify  /trunk/src/google/protobuf/message.cc   diff
...                     
32      32              //  Based on original Protocol Buffers design by
33      33              //  Sanjay Ghemawat, Jeff Dean, and others.
34      34              
35      +       #include <iostream>
35      36              #include <stack>
36      37              #include <google/protobuf/stubs/hash.h>
37      38              
...             

You should not #include <iostream> here. This is an expensive header. All that is needed is #include <istream> as shown in http://code.google.com/p/protobuf/issues/detail?id=455

<iostream> is for using std::cout, std::cin, etc. <istream> is for defining std::basic_istream, which is what is required here.


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups "Protocol 
Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/protobuf?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to