Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium
New issue 474 by vap...@google.com: fix handling of Atomic64 on x32 ABIs
http://code.google.com/p/protobuf/issues/detail?id=474
the file src/google/protobuf/stubs/atomicops.h has this snippet:
typedef int32 Atomic32;
#ifdef GOOGLE_PROTOBUF_ARCH_64_BIT
// We need to be able to go between Atomic64 and AtomicWord implicitly.
This
// means Atomic64 and AtomicWord should be the same type on 64-bit.
#if defined(GOOGLE_PROTOBUF_OS_NACL)
// NaCl's intptr_t is not actually 64-bits on 64-bit!
// http://code.google.com/p/nativeclient/issues/detail?id=1162
typedef int64 Atomic64;
#else
typedef intptr_t Atomic64;
#endif
#endif
nacl has this because it's really the x32 abi where pointers are 32bits but
can do 64bit values natively. i merged a patch to chromium's base code
that fixes it thusly:
https://codereview.chromium.org/12186005/
-#if defined(GOOGLE_PROTOBUF_OS_NACL)
+#if defined(__ILP32__) || defined(GOOGLE_PROTOBUF_OS_NACL)
i didn't see a codereview site for this project, so i'm submitting the
patch via the issue tracker
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups "Protocol
Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
