Done as https://github.com/google/protobuf/issues/633.

On Tue, Jul 21, 2015 at 2:36 PM, Feng Xiao <xiaof...@google.com> wrote:

>
>
> On Tue, Jul 21, 2015 at 2:09 PM, Brian Silverman <bsilver16...@gmail.com>
> wrote:
>
>> Hi,
>>
>> I'm running the protobuf tests under AddressSanitizer using the Bazel
>> BUILD file, and DynamicMessageTest.Oneof triggers a heap-use-after-free
>> failure. It looks like the issue is half-implemented ctype=CORD support for
>> strings in C++. DynamicMessage doesn't look like it even attempts to handle
>> cords.
>>
>> Commenting out all of the uses of bar_cord
>> in src/google/protobuf/test_util.cc makes the tests pass. I know
>> use-after-free is not correct behavior, but I don't know what the desired
>> behavior is. Should the open source protobuf compiler completely reject
>> ctype=CORD or are there just a few pieces which need to be fixed to make it
>> work?
>>
> Opensource code should just ignore the ctype=CORD option. Sounds like the
> field option is not handled correctly for oneofs in DynamicMessage.
>
> Could you help file an issue for this bug?
>
>
>>
>> Thanks,
>> Brian Silverman
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Protocol Buffers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to protobuf+unsubscr...@googlegroups.com.
>> To post to this group, send email to protobuf@googlegroups.com.
>> Visit this group at http://groups.google.com/group/protobuf.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.

Reply via email to