Great, that should be a safe change to patch then. I submitted this today here <https://github.com/protocolbuffers/protobuf/commit/435c182ae66906891d4345159577a11ae5addbf7>, but it will take some time for that change to make it into a release.
On Tue, Jun 11, 2024 at 5:40 AM 'Ky Waegel' via Protocol Buffers < [email protected]> wrote: > Yes, that seems to work. > > On Friday, June 7, 2024 at 2:50:24 PM UTC-7 Adam Cozzette wrote: > >> Does putting an asterisk in front of pb::* here >> <https://github.com/protocolbuffers/protobuf/blob/54d8f03974c108ef8fd0f26568cd9eb086165568/src/libprotobuf.map#L5> >> fix the problem? I think we're trying to export everything under the pb >> namespace, but for some reason the type info for pb::CppFeatures is not >> getting exported. >> >> On Thu, Jun 6, 2024 at 5:04 PM 'Ky Waegel' via Protocol Buffers < >> [email protected]> wrote: >> >>> I've been working to build Protobuf with ASan and/or UBSan support >>> (mostly for compatibility with a containing project), and I've been running >>> into some weird symbol visibility errors. Example trying to run `protoc` >>> with "-fsanitize=address" enabled: >>> >>> protobuf-27.1/libprotoc.so.27.1.0: undefined symbol: >>> _ZTIN2pb11CppFeaturesE >>> >>> I initially thought this was just a weird quirk in my build system, but >>> then I discovered this patch >>> <https://fossies.org/linux/mysql/extra/protobuf/protobuf-24.4/src/libprotobuf.map> >>> to a vendored copy of Protobuf inside of MySQL 8.4.0 that reference the >>> same symbol, mentions that the change is required for UBSan support, and >>> fixes my symbol issue. >>> >>> Anyone know what's going on here? Asking here before filing a bug >>> because I'm not entirely sure if this is a bug, or of I'm (ab)using the >>> build flags somehow. >>> >>> (Initially ran into this with v24.3, but the same thing happens with >>> v27.1.) >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Protocol Buffers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/protobuf/69654ee7-b09e-405c-b9ad-d5ad8709f1b8n%40googlegroups.com >>> <https://groups.google.com/d/msgid/protobuf/69654ee7-b09e-405c-b9ad-d5ad8709f1b8n%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to the Google Groups > "Protocol Buffers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/protobuf/9b8acea7-bee4-4060-9ccd-019f0a2a49c1n%40googlegroups.com > <https://groups.google.com/d/msgid/protobuf/9b8acea7-bee4-4060-9ccd-019f0a2a49c1n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/protobuf/CADqAXr6n_111Lme0D72EnzAkcgJiz7PFvaaGSX%3DyDnasmVgArw%40mail.gmail.com.
