Ok, go ahead as long as it doesn't make things worse wrt windows porting.

--Rafael

On Thu, Oct 25, 2012 at 11:05 AM, Mary Hinton <m.hin...@nc.rr.com> wrote:

> libgen.h - definitions for pattern matching functions
>
> Some of the other proton headers that are being used now are not part of
> the
> Visual Studio compiler header files
> I've been doing #ifdef (s) around the header files. E.g.
>         #include <unistd.h>
>         #include <stdbool.h>
>
> -----Original Message-----
> From: Rafael Schloming [mailto:r...@alum.mit.edu]
> Sent: Thursday, October 25, 2012 10:49 AM
> To: proton@qpid.apache.org
> Subject: Re: RC3
>
> What's libgen.h? Is that available on windows?
>
> --Rafael
>
> On Thu, Oct 25, 2012 at 10:38 AM, Darryl L. Pierce
> <dpie...@redhat.com>wrote:
>
> > On Wed, Oct 24, 2012 at 03:29:44PM -0400, Rafael Schloming wrote:
> > > I've put up an RC3 here:
> > >
> > >   http://people.apache.org/~rhs/qpid-proton-0.1rc3/
> > >
> > > The following are the changes from RC2:
> > >
> > >   - added README and LICENSE for proton-j
> > >   - updated the proton-c README
> > >   - fixed cmake build to not use the OPTIONAL thing for older versions
> > >   - fixed detection of LIB_SUFFIX (i.e. we won't install into lib64
> > > on 32 bit systems anymore)
> >
> > I have a small fix for the proton binary that removes the pathname for
> > the binary in the usage output:
> >
> > diff --git a/proton-c/src/proton.c b/proton-c/src/proton.c index
> > 0473fdf..0969538 100644
> > --- a/proton-c/src/proton.c
> > +++ b/proton-c/src/proton.c
> > @@ -27,6 +27,7 @@
> >  #include <proton/message.h>
> >  #include <proton/util.h>
> >  #include <unistd.h>
> > +#include <libgen.h>
> >  #include "util.h"
> >  #include "pn_config.h"
> >  #include <proton/codec.h>
> > @@ -426,7 +427,7 @@ int main(int argc, char **argv)
> >        buffer(argc, argv);
> >        exit(EXIT_SUCCESS);
> >      case 'h':
> > -      printf("Usage: %s [-h] [-c [user[:password]@]host[:port]] [-a
> >        <address>] [-m <sasl-mech>]\n", argv[0]);
> > +      printf("Usage: %s [-h] [-c [user[:password]@]host[:port]] [-a
> > <address>] [-m <sasl-mech>]\n", basename(argv[0]));
> >        printf("\n");
> >        printf("    -c    The connect url.\n");
> >        printf("    -a    The AMQP address.\n");
> >
> > I'd like to commit this to keep the hostname from showing up in
> > packaged binaries.
> >
> > --
> > Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
> > Delivering value year after year.
> > Red Hat ranks #1 in value among software vendors.
> > http://www.redhat.com/promo/vendor/
> >
> >
>
>
>

Reply via email to