[
https://issues.apache.org/jira/browse/PROTON-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489671#comment-13489671
]
Hiram Chirino commented on PROTON-114:
--------------------------------------
Rafael, your patch fixes the deliveryCount problem and still keeps all the test
passing. Nice!
> proton-j sender.drained() sends Flow with invalid deliveryCount
> ---------------------------------------------------------------
>
> Key: PROTON-114
> URL: https://issues.apache.org/jira/browse/PROTON-114
> Project: Qpid Proton
> Issue Type: Bug
> Reporter: Hiram Chirino
> Attachments: credit.patch, PROTON-114.patch
>
>
> so the proton-j sender gets a drain request...
> RECV: 00000 | Flow{nextIncomingId=2, incomingWindow=2048, nextOutgoingId=1,
> outgoingWindow=2048, handle=1, deliveryCount=1, linkCredit=99,
> available=null, drain=true, echo=false, properties=null}
> then we call sender.drained(), and it sends:
> SENT: 00000 | Flow{nextIncomingId=1, incomingWindow=1024, nextOutgoingId=2,
> outgoingWindow=1023, handle=1, deliveryCount=1, linkCredit=0, available=null,
> drain=true, echo=false, properties=null}
> Notice that Flow{… deliveryCount=1, ...} but I would expect the flow to be
> Flow{… deliveryCount=100, ...} since the link had 99 credits remaining
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
