[ 
https://issues.apache.org/jira/browse/PROTON-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506767#comment-13506767
 ] 

Hiram Chirino commented on PROTON-168:
--------------------------------------

Hi Andrew,

Warnings would still be on, and you can seem them when you build.  The change 
only disables failing the build when on OS X due to the warnings.  Until all 
warnings are resolved on OS X, I see no other sensible solution.

A slightly buggy build is better than no build at all in my book.

Here are the warnings:

/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c: In function 
‘_log_ssl_error’:
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:134: warning: 
‘ERR_get_error’ is deprecated (declared at /usr/include/openssl/err.h:266)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:136: warning: 
‘ERR_error_string_n’ is deprecated (declared at /usr/include/openssl/err.h:280)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:138: warning: 
‘ERR_get_error’ is deprecated (declared at /usr/include/openssl/err.h:266)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c: In function 
‘ssl_failed’:
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:158: warning: 
‘ERR_get_error’ is deprecated (declared at /usr/include/openssl/err.h:266)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:160: warning: 
‘ERR_error_string_n’ is deprecated (declared at /usr/include/openssl/err.h:280)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c: In function 
‘get_dh2048’:
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:250: warning: ‘DH_new’ 
is deprecated (declared at /usr/include/openssl/dh.h:184)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:251: warning: 
‘BN_bin2bn’ is deprecated (declared at /usr/include/openssl/bn.h:422)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:252: warning: 
‘BN_bin2bn’ is deprecated (declared at /usr/include/openssl/bn.h:422)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:254: warning: 
‘DH_free’ is deprecated (declared at /usr/include/openssl/dh.h:185)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c: In function 
‘pn_ssl_set_credentials’:
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:273: warning: 
‘SSL_CTX_use_certificate_chain_file’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1403)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:280: warning: 
‘SSL_CTX_set_default_passwd_cb’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1472)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:281: warning: 
‘SSL_CTX_set_default_passwd_cb_userdata’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1473)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:284: warning: 
‘SSL_CTX_use_PrivateKey_file’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1401)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:289: warning: 
‘SSL_CTX_check_private_key’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1475)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:300: warning: 
‘SSL_CTX_set_cipher_list’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1345)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c: In function 
‘pn_ssl_set_trusted_ca_db’:
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:337: warning: 
‘SSL_CTX_load_verify_locations’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1572)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c: In function 
‘pn_ssl_set_peer_authentication’:
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:398: warning: 
‘SSL_load_client_CA_file’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1404)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:400: warning: 
‘SSL_CTX_set_client_CA_list’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1542)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:407: warning: 
‘SSL_CTX_set_verify’ is deprecated (declared at /usr/include/openssl/ssl.h:1459)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:416: warning: 
‘SSL_CTX_set_verify’ is deprecated (declared at /usr/include/openssl/ssl.h:1459)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c: In function 
‘pn_ssl_get_cipher_name’:
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:457: warning: 
‘SSL_get_current_cipher’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1357)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:458: warning: 
‘SSL_CIPHER_get_name’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1360)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c: In function 
‘pn_ssl_get_protocol_name’:
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:472: warning: 
‘SSL_get_current_cipher’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1357)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:473: warning: 
‘SSL_CIPHER_get_version’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1359)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c: In function 
‘pn_ssl_init’:
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:494: warning: 
‘SSL_CTX_free’ is deprecated (declared at /usr/include/openssl/ssl.h:1347)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:500: warning: 
‘SSL_CTX_new’ is deprecated (declared at /usr/include/openssl/ssl.h:1346)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:500: warning: 
‘SSLv23_client_method’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1517)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:510: warning: 
‘SSL_CTX_new’ is deprecated (declared at /usr/include/openssl/ssl.h:1346)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:510: warning: 
‘SSLv23_server_method’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1516)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:523: warning: 
‘SSL_CTX_set_cipher_list’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1345)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:535: warning: 
‘SSL_CTX_ctrl’ is deprecated (declared at /usr/include/openssl/ssl.h:1498)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:536: warning: 
‘DH_free’ is deprecated (declared at /usr/include/openssl/dh.h:185)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:537: warning: 
‘SSL_CTX_ctrl’ is deprecated (declared at /usr/include/openssl/ssl.h:1498)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c: In function ‘pn_ssl’:
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:550: warning: 
‘SSL_library_init’ is deprecated (declared at /usr/include/openssl/ssl.h:1553)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:551: warning: 
‘SSL_load_error_strings’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1416)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:552: warning: 
‘OPENSSL_add_all_algorithms_noconf’ is deprecated (declared at 
/usr/include/openssl/evp.h:828)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c: In function 
‘pn_ssl_free’:
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:578: warning: 
‘BIO_free’ is deprecated (declared at /usr/include/openssl/bio.h:583)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:579: warning: 
‘SSL_free’ is deprecated (declared at /usr/include/openssl/ssl.h:1490)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:581: warning: 
‘BIO_free’ is deprecated (declared at /usr/include/openssl/bio.h:583)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:582: warning: 
‘BIO_free’ is deprecated (declared at /usr/include/openssl/bio.h:583)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:584: warning: 
‘SSL_CTX_free’ is deprecated (declared at /usr/include/openssl/ssl.h:1347)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c: In function 
‘process_input_ssl’:
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:658: warning: 
‘BIO_write’ is deprecated (declared at /usr/include/openssl/bio.h:587)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:671: warning: 
‘BIO_ctrl’ is deprecated (declared at /usr/include/openssl/bio.h:590)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:678: warning: 
‘BIO_read’ is deprecated (declared at /usr/include/openssl/bio.h:585)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:685: warning: 
‘BIO_test_flags’ is deprecated (declared at /usr/include/openssl/bio.h:208)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:686: warning: 
‘SSL_get_error’ is deprecated (declared at /usr/include/openssl/ssl.h:1501)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:699: warning: 
‘BIO_test_flags’ is deprecated (declared at /usr/include/openssl/bio.h:208)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:703: warning: 
‘BIO_test_flags’ is deprecated (declared at /usr/include/openssl/bio.h:208)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:754: warning: 
‘SSL_get_shutdown’ is deprecated (declared at /usr/include/openssl/ssl.h:1568)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c: In function 
‘process_output_ssl’:
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:794: warning: 
‘BIO_write’ is deprecated (declared at /usr/include/openssl/bio.h:587)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:801: warning: 
‘BIO_test_flags’ is deprecated (declared at /usr/include/openssl/bio.h:208)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:802: warning: 
‘SSL_get_error’ is deprecated (declared at /usr/include/openssl/ssl.h:1501)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:816: warning: 
‘BIO_test_flags’ is deprecated (declared at /usr/include/openssl/bio.h:208)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:820: warning: 
‘BIO_test_flags’ is deprecated (declared at /usr/include/openssl/bio.h:208)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:841: warning: 
‘BIO_read’ is deprecated (declared at /usr/include/openssl/bio.h:585)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:865: warning: 
‘SSL_get_shutdown’ is deprecated (declared at /usr/include/openssl/ssl.h:1568)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:865: warning: 
‘BIO_ctrl’ is deprecated (declared at /usr/include/openssl/bio.h:590)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c: In function 
‘init_ssl_socket’:
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:876: warning: 
‘SSL_new’ is deprecated (declared at /usr/include/openssl/ssl.h:1481)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:883: warning: 
‘BIO_new’ is deprecated (declared at /usr/include/openssl/bio.h:581)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:888: warning: 
‘BIO_ctrl’ is deprecated (declared at /usr/include/openssl/bio.h:590)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:891: warning: 
‘BIO_new_bio_pair’ is deprecated (declared at /usr/include/openssl/bio.h:682)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:895: warning: 
‘SSL_set_bio’ is deprecated (declared at /usr/include/openssl/ssl.h:1375)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:898: warning: 
‘SSL_set_accept_state’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1549)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:899: warning: 
‘BIO_ctrl’ is deprecated (declared at /usr/include/openssl/bio.h:590)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:902: warning: 
‘SSL_set_connect_state’ is deprecated (declared at 
/usr/include/openssl/ssl.h:1548)
/Users/chirino/sandbox/proton/proton-c/src/ssl/openssl.c:903: warning: 
‘BIO_ctrl’ is deprecated (declared at /usr/include/openssl/bio.h:590)
/Users/chirino/sandbox/proton/proton-c/include/proton/engine.h:67: Warning 451: 
Setting a const char * variable may leak memory.
/Users/chirino/sandbox/proton/proton-c/include/proton/engine.h:67: Warning 451: 
Setting a const char * variable may leak memory.
/Users/chirino/sandbox/proton/proton-c/include/proton/cproton.i:25: Warning 
302: Identifier 'uint32_t' redefined (ignored),
/Users/chirino/sandbox/proton/proton-c/bindings/ruby/ruby.i:33: Warning 302: 
previous definition of 'uint32_t'.
/Users/chirino/sandbox/proton/proton-c/include/proton/cproton.i:26: Warning 
302: Identifier 'int32_t' redefined (ignored),
/Users/chirino/sandbox/proton/proton-c/bindings/ruby/ruby.i:35: Warning 302: 
previous definition of 'int32_t'.
/Users/chirino/sandbox/proton/proton-c/include/proton/cproton.i:27: Warning 
302: Identifier 'uint64_t' redefined (ignored),
/Users/chirino/sandbox/proton/proton-c/bindings/ruby/ruby.i:34: Warning 302: 
previous definition of 'uint64_t'.
/Users/chirino/sandbox/proton/proton-c/include/proton/types.h:39: Warning 801: 
Wrong class name (corrected to `Pn_decimal128_t')
/Users/chirino/sandbox/proton/proton-c/include/proton/types.h:39: Warning 801: 
Wrong class name (corrected to `Pn_decimal128_t')
/Users/chirino/sandbox/proton/proton-c/include/proton/types.h:42: Warning 801: 
Wrong class name (corrected to `Pn_uuid_t')
/Users/chirino/sandbox/proton/proton-c/include/proton/types.h:42: Warning 801: 
Wrong class name (corrected to `Pn_uuid_t')
/Users/chirino/sandbox/proton/proton-c/include/proton/types.h:46: Warning 801: 
Wrong class name (corrected to `Pn_bytes_t')
/Users/chirino/sandbox/proton/proton-c/include/proton/types.h:46: Warning 801: 
Wrong class name (corrected to `Pn_bytes_t')
/Users/chirino/sandbox/proton/proton-c/include/proton/engine.h:65: Warning 801: 
Wrong class name (corrected to `Pn_delivery_tag_t')
/Users/chirino/sandbox/proton/proton-c/include/proton/engine.h:65: Warning 801: 
Wrong class name (corrected to `Pn_delivery_tag_t')
/Users/chirino/sandbox/proton/proton-c/include/proton/engine.h:67: Warning 451: 
Setting a const char * variable may leak memory.
/Users/chirino/sandbox/proton/proton-c/include/proton/codec.h:63: Warning 801: 
Wrong class name (corrected to `Pn_atom_t')
/Users/chirino/sandbox/proton/proton-c/include/proton/codec.h:63: Warning 801: 
Wrong class name (corrected to `Pn_atom_t')
/Users/chirino/sandbox/proton/proton-c/include/proton/codec.h:85: Warning 801: 
Wrong class name (corrected to `Pn_atom_t_u')
/Users/chirino/sandbox/proton/proton-c/include/proton/codec.h:85: Warning 801: 
Wrong class name (corrected to `Pn_atom_t_u')
/Users/chirino/sandbox/proton/proton-c/bindings/ruby/rubyRUBY_wrap.c: In 
function ‘_wrap_pn_message_set_user_id’:
/Users/chirino/sandbox/proton/proton-c/bindings/ruby/rubyRUBY_wrap.c:7674: 
warning: return makes integer from pointer without a cast
/Users/chirino/sandbox/proton/proton-c/bindings/ruby/rubyRUBY_wrap.c: In 
function ‘_wrap_pn_data_put_binary’:
/Users/chirino/sandbox/proton/proton-c/bindings/ruby/rubyRUBY_wrap.c:13902: 
warning: return makes integer from pointer without a cast
/Users/chirino/sandbox/proton/proton-c/bindings/ruby/rubyRUBY_wrap.c: In 
function ‘_wrap_pn_data_put_string’:
/Users/chirino/sandbox/proton/proton-c/bindings/ruby/rubyRUBY_wrap.c:13939: 
warning: return makes integer from pointer without a cast
/Users/chirino/sandbox/proton/proton-c/bindings/ruby/rubyRUBY_wrap.c: In 
function ‘_wrap_pn_data_put_symbol’:
/Users/chirino/sandbox/proton/proton-c/bindings/ruby/rubyRUBY_wrap.c:13976: 
warning: return makes integer from pointer without a cast

                
> Support for building on OS X
> ----------------------------
>
>                 Key: PROTON-168
>                 URL: https://issues.apache.org/jira/browse/PROTON-168
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-c
>         Environment: Mac OS X Lion
>            Reporter: Andy Goldstein
>            Priority: Minor
>         Attachments: clock.patch, nowerror.patch, proton-168.patch, 
> PROTON-168-v2.patch, SO_NOSIGPIPE.patch
>
>
> I did some quick "hacky" work to get proton-c to compile on my Mac running 
> Lion.  I also have homebrew installed and use that to supply any libraries 
> that are necessary but not included by default on the Mac.  I'm attaching my 
> quick patch, and it would be great if someone could take it and update it so 
> it's more robust and commit-quality :-)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to