Andrew Stitcher commented on PROTON-170:

No problem with the comment change! (although I did copy the initial file 
directly from qpid so I expect the same problem exists there)

I'm not 100% sure about the fix you've got there since I don't think that 
CMAKE_INSTALL_PREFIX has to be an absolute path (and I seem to remember 
discussing with Rafi that in fact that is the way he uses CMAKE_INSTALL_PREFIX).

I think it'd be more flexible to add in definitions for LIBDIR and INCLUDEDIR 
to CMakeLists.txt rather than change the .pc file (that is how we do it in 
qpid) - it seems I just failed to copy it over correctly from qpid and didn't 
> generated pkg config file is broken
> -----------------------------------
>                 Key: PROTON-170
>                 URL: https://issues.apache.org/jira/browse/PROTON-170
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.2
>            Reporter: Gordon Sim
>            Assignee: Andrew Stitcher
>         Attachments: PROTON-170.patch
> E.g. cmake -DCMAKE_INSTALL_PREFIX=/path/to/non-standard/install && make 
> install will install a pkg config file that doesn't have the include and lib 
> directories set.
> Also Cflags is set to -I${includedir} which breaks compilation even for a 
> standard install if the includedir is not set.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to