[ https://issues.apache.org/jira/browse/PROTON-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510841#comment-13510841 ]
Andrew Stitcher commented on PROTON-121: ---------------------------------------- Another example is the use of strcasecmp() which again is not part of ANSI C. > Platform specific code is mixed in with platform independent code > ----------------------------------------------------------------- > > Key: PROTON-121 > URL: https://issues.apache.org/jira/browse/PROTON-121 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c > Reporter: Andrew Stitcher > > the function pn_error_from errno() is platform specific and so should not be > in error.c which is (everywhere else) purely platform independent. > It should be moved to a platform (POSIX) specific file (perhaps a file with > only this single function). > [The clue for this is the #define POSIX_C_SOURCE at the top of error.c] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira