[ https://issues.apache.org/jira/browse/PROTON-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575876#comment-13575876 ]
Ken Giusti commented on PROTON-225: ----------------------------------- I'd recommend the following tweak to the proposed api: /** Push data from a transport's input buffer into the engine and * return how much data was succesfully pushed. * * @param[in] transport the transport * @param[size] the amount of data in the transport's input buffer * @return the amount of data consumed */ - size_t pn_transport_push(pn_transport_t *transport, size_t size); + ssize_t pn_transport_push(pn_transport_t *transport, size_t size); >From an implementation's point of view - the "push" will end up processing the >new data. This could result in a failure, and the method's return value >should be able to reflect that. > Redesign Transport interface such that Transport owns the in/out buffers > rather than its client > ----------------------------------------------------------------------------------------------- > > Key: PROTON-225 > URL: https://issues.apache.org/jira/browse/PROTON-225 > Project: Qpid Proton > Issue Type: Improvement > Affects Versions: 0.3 > Reporter: Philip Harvey > Fix For: 0.5 > > > This issue is intended to cover the Transport API redesign proposed on the > mailing list > (http://qpid.2158936.n2.nabble.com/transport-interface-changes-td7588099.html) > as part of discussions around PROTON-222. The redesign is being tracked > under this new because we probably want to implement it on a different > timescale to the PROTON-222 bug fix. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira