Rafael H. Schloming commented on PROTON-200:

I'd say first priority for 0.4 is the -1 fix. My sense is re-balancing properly 
is going to be a 0.5 thing, however if we get the -1 fix in and have extra time 
and it turns out to be low risk, I'm not opposed to rebalancing for 0.4.

On the DoS topic, while I agree there are a number of potential DoSes here, I 
don't think the -1 patch really makes them any worse. In some ways the DoS 
issue is orthogonal. Currently we could be DoSed anyways by simply holding 
connections open without involving links at all. I think to address the DoS 
issue we need a more general inactivity timer. With that in place it would not 
only address a more general class of DoS, but in this case it would cause the 
links held by that client to close and their credit to be reclaimed (i.e. doing 
a primitive destructive sort of rebalancing).
> [Proton-c] Credit distribution by messenger is not balanced across all links
> ----------------------------------------------------------------------------
>                 Key: PROTON-200
>                 URL: https://issues.apache.org/jira/browse/PROTON-200
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.3
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>             Fix For: 0.4
>         Attachments: proton-200.patch
> The method used to distribute credit to receiving links may lead to 
> starvation when the number of receiving links is > the available credit.
> The distribution algorithm always starts with the same link - see 
> messenger.c::pn_messenger_flow()

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to