[ https://issues.apache.org/jira/browse/PROTON-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13730711#comment-13730711 ]
Philip Harvey commented on PROTON-343: -------------------------------------- As of now, most of the logging framework code has been implemented but is not yet being used. Here is my list of what needs to be done to achieve this: * Implement the main methods we need on EngineLogger. These are currently: ** sentFrame ** receivedFrame ** sentBytes ** receivedBytes (replacing java.util.Logger in FrameParser) ** possibly from SASL-related state information, e.g. saslOutcome(outcome) ** possibly from SSL-related state information, e.g. sslDetected(true) * Add a new Frame interface to proton-api for use by EngineLogger.sendFrame * Replace uses of ProtocolTracer with EngineLogger. These are currently : ** _protocolTracer.sentFrame(TransportFrame) in FrameWriter ** _protocolTracer.receivedFrame(TransportFrame) in TransportImpl * Implement one or more DriverLogger onError() (or similar) methods to replace the existing use of java.util.logging > Add a pluggable Proton logging layer > ------------------------------------ > > Key: PROTON-343 > URL: https://issues.apache.org/jira/browse/PROTON-343 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c, proton-j > Reporter: Philip Harvey > Assignee: Philip Harvey > Attachments: > 0001-PROTON-343-sketched-out-the-Java-parts-of-the-propos.patch > > > Applications that use Proton sometimes want Proton to produce logging. > Goals > ==== > * Proton should provide a default logging implementation. > * It should be easy for Proton client code to provide custom logging > implementation, e.g. one that uses the same third party logging framework as > their application code. > * Proton should not have a compile-time dependency on a third party logging > framework > * Proton's log output is considered to be part of its public interface. > Therefore, in the spirit of Proton's cross-language consistency goals, this > output should be consistent between proton-c and proton-j. > * The goals that general-purpose logging frameworks try to meet - > performance, ease of use etc - also apply. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira