[ 
https://issues.apache.org/jira/browse/PROTON-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cliff Jansen resolved PROTON-122.
---------------------------------

    Resolution: Fixed

fixed in PROTON-159
                
> Porting Issue  -- Visual Studio compilers have different header files
> ---------------------------------------------------------------------
>
>                 Key: PROTON-122
>                 URL: https://issues.apache.org/jira/browse/PROTON-122
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-c
>         Environment: Windows using Visual Studio 10
>            Reporter: Mary hinton
>            Assignee: Cliff Jansen
>             Fix For: 0.4
>
>
> Visual Studio compilers have different header files.
> I looked through the files that qpid cpp uses for including Visual Studio 
> header files. 
> It looks like most of the diffences in header files are set up in Boost.
> Boost uses the macro BOOST_WINDOWS.
> Maybe we could use PROTON_WINDOWS for including the windows header files. 
> If you don't want a new macro, we can use one of the Visual Studio specific  
> macro (_WINDOWS) 
> for the header files.
> It's not really a CPLUSPLUS vs. C issue, since many of the header files are 
> specific to Windows.
> (for example winsock2.h which is used by C++ and C in Visual Studio).
> Also, some of the current header files are not used on Windows, but may be 
> used by CYGWIN or MinGW.
> If this sounds okay, I'll set up a patch for including the necessary windows 
> header files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to