[
https://issues.apache.org/jira/browse/PROTON-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882918#comment-13882918
]
Ken Giusti commented on PROTON-496:
-----------------------------------
True, but shouldn't Messenger be a "good citizen" and do the right thing? Esp
given that I think a fix is trivial:
====
diff --git a/proton-c/src/messenger/messenger.c
b/proton-c/src/messenger/messenger.c
index 7f67050..384cffa 100644
--- a/proton-c/src/messenger/messenger.c
+++ b/proton-c/src/messenger/messenger.c
@@ -949,6 +949,11 @@ int pn_messenger_stop(pn_messenger_t *messenger)
pn_link_close(link);
link = pn_link_next(link, PN_LOCAL_ACTIVE);
}
+ pn_session_t *ssn = pn_session_head(conn, PN_LOCAL_ACTIVE);
+ while (ssn) {
+ pn_session_close(ssn);
+ ssn = pn_session_next(ssn, PN_LOCAL_ACTIVE);
+ }
pn_connection_close(conn);
ctor = pn_connector_next(ctor);
}
====
But you're correct - not a bug, I'll modify this Jira accordingly.
> [Messenger] Messenger fails to send "end" on shutdown.
> ------------------------------------------------------
>
> Key: PROTON-496
> URL: https://issues.apache.org/jira/browse/PROTON-496
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Affects Versions: 0.6
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Trivial
> Fix For: 0.7
>
>
> $ export PN_TRACE_FRM=1
> $ proton-c/examples/messenger/c/send
> Connected to 0.0.0.0:5672
> [0x151a020]: -> SASL
> [0x151a020]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, initial-response=b""]
> [0x151a020]: <- SASL
> <SNIP>
> [0x151a020]:0 -> @detach(22) [handle=0, closed=true]
> [0x151a020]:0 -> @close(24) []
> [0x151a020]: -> EOS
> [0x151a020]:0 <- @detach(22) [handle=0, closed=true]
> [0x151a020]:0 <- @close(24) []
> [0x151a020]: <- EOS
> Closed 0.0.0.0:5672
> There should be an "@end" frame in there, no?
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
