Thanks for the Javascript related info. Fraser: can you test if the review board patch (with the struct "in and out" strategy) works in your case with the unhacked llvm setup? If that works then I'll go ahead and check it in.
If it fails, please try the first patch. If that works, we will just have to conclude that compilers have trouble with stucts in this case and fall back to passing the two basic types. That should be safe to work in the greatest number of cases. Many thanks. On Mon, Jan 27, 2014 at 1:13 PM, Fraser Adams (JIRA) <j...@apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/PROTON-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883314#comment-13883314 > ] > > Fraser Adams commented on PROTON-488: > ------------------------------------- > > Oh to be clear > either "struct in and out", or "separate size_t and char* in and out" > > what I meant in my previous comment was that the separate size_t and char* in > and out is what LLVM le32 is happiest with, the structs seem to confuse it, I > hadn't realised that you'd changed your original patch to now do "all 'z' > encodings to be passed as a single pn_bytes_t struct and "retrieved" as a > single pn_bytes_t struct" - although this arguably looks neater I'd > definitely prefer your first approach. > >> Windows 7 64-bit VS2010 qpid-proton Crash on Startup with Send / Recv >> Application >> --------------------------------------------------------------------------------- >> >> Key: PROTON-488 >> URL: https://issues.apache.org/jira/browse/PROTON-488 >> Project: Qpid Proton >> Issue Type: Bug >> Components: proton-c >> Affects Versions: 0.6 >> Environment: Windows 7 64-bit VS 2010 >> Reporter: Frank Quinn >> Assignee: Cliff Jansen >> Priority: Critical >> Attachments: PROTON-488-0.patch, qpid-proton-win64-send-crash.png >> >> >> Steps to recreate: >> 1. Grab latest 0.6 tarball >> 2. Start up Visual Studio x64 Win64 Command Prompt (2010) and run "cmake ." >> to generate the visual studio files >> 3. Open Up the newly created Proton.sln in VS2010, right click on >> qpid-proton and add the path to python to executable directories >> 4. In the configuration manager, select qpid-proton and select active >> configuration to be Debug, then select "Add" to add x64 support, copying >> win32 configuration in the process. >> 5. Select qpid-proton properties and remove the hard coded /machine:X86 >> extra command lines in Linker -> Command Line (MACHINE:X64 should already be >> in the command line above so no need to add here) >> 6. Right click on qpid-proton and select build >> Repeat steps 3-6 for send / recv applications. When you run recv, then run >> send, you'll get a crash with the (soon to be attached) trace. >> Cheers, >> Frank > > > > -- > This message was sent by Atlassian JIRA > (v6.1.5#6160)
