[
https://issues.apache.org/jira/browse/PROTON-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144717#comment-14144717
]
Bozo Dragojevic commented on PROTON-660:
----------------------------------------
{quote}
So the real solution is a oneliner in ../platform.h to include winsock.h on
windows. wdyt?
{quote}
.. which is then suspiciously close to what Dominic did. :) Dominic, I saw you
only included wincrypt.h ahead of time
so you only have issues with {{#define small}}. If you include the whole
winsock.h (as windows/io.c does it)
then one gets an additional issue with {{#define ERROR}}. In any case I'd
propose we move the needed #undefs to the platform.h.
I'm thinking it'd make sense to do an include cleanup to make all of this less
fragile and always have the same order of different includes
# system includes
# platform.h
# proton public includes
# proton private includes
sometimes now they are mixed up a bit and it's hard to make sure that
platform.h (un)does all platform-specific fixups
> Fix openssl.c build on windows
> ------------------------------
>
> Key: PROTON-660
> URL: https://issues.apache.org/jira/browse/PROTON-660
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: 0.8
> Environment: Windows 7, VS2013
> Reporter: Bozo Dragojevic
> Attachments: 0001-PROTON-660-Fix-openssl.c-build-on-windows.patch,
> 25_openssl_fix_for_windows_CMakeLists.patch,
> 25_openssl_fix_for_windows_data.h.patch,
> 25_openssl_fix_for_windows_platform.h.patch
>
>
> Compiled openssl-1.0.1i from source
> Proton finds it, but openssl.c does not compile without small adjustments.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
