As a workaround, I've applied the patch to a svn checkout and uploaded svn diff. That works, but is a bit clumsy...
Bozzo On 25. 09. 14 20:50, Bozo Dragojevic wrote: > Can somebody help me with the reviewboard, please? > > I wanted to stuff this patch to reviewboard, but it gets rejected with: > > The specified diff file could not be parsed. > Line 19: No valid separator after the filename was found in the diff header > > > I selected repository 'qpid' > I uploaded the patch below > I selected base directory /proton/trunk (I have also tried > /qpid/proton/trunk with same effect) > > fwiw, I'm doing this from a mac using chrome > > Bozzo > > On 25. 09. 14 20:44, Bozo Dragojevic (JIRA) wrote: >> [ >> https://issues.apache.org/jira/browse/PROTON-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >> ] >> >> Bozo Dragojevic updated PROTON-660: >> ----------------------------------- >> Attachment: (was: >> 0001-PROTON-660-Fix-openssl.c-build-on-windows.patch) >> >>> Fix openssl.c build on windows >>> ------------------------------ >>> >>> Key: PROTON-660 >>> URL: https://issues.apache.org/jira/browse/PROTON-660 >>> Project: Qpid Proton >>> Issue Type: Bug >>> Components: proton-c >>> Affects Versions: 0.8 >>> Environment: Windows 7, VS2013 >>> Reporter: Bozo Dragojevic >>> Attachments: 25_openssl_fix_for_windows_CMakeLists.patch, >>> 25_openssl_fix_for_windows_data.h.patch, >>> 25_openssl_fix_for_windows_platform.h.patch >>> >>> >>> Compiled openssl-1.0.1i from source >>> Proton finds it, but openssl.c does not compile without small adjustments. >> >> -- >> This message was sent by Atlassian JIRA >> (v6.3.4#6332)
