Rafi could u pls answer the two questions I had in the code? 1. Your uint method only takes an int .. shouldn't it take a long? Bcos it could contain a value larger than a java int?
2. What should I use for boolean? there is no getBoolean .. or an equivalent method Regards, Rajith On Wed, Jan 28, 2015 at 3:06 PM, Rajith Muditha Attapattu < rajit...@gmail.com> wrote: > > On Wed, Jan 28, 2015 at 2:23 PM, Rafael Schloming <r...@alum.mit.edu> > wrote: > >> On Wed, Jan 28, 2015 at 2:01 PM, Rajith Muditha Attapattu < >> rajit...@gmail.com> wrote: >> >> > Rafi, >> > >> > I just checked in some skeleton code to explore a particular approach. >> > It avoids the intermediate objects we have in proton now (Ex >> FlowType.java) >> > Instead the Flow class is directly used by the encoding/decoding layer. >> > >> > The Flow class uses java types as opposed to AMQP specific types, which >> > will address one of your main concerns. >> > >> > The code is checked into the "rajith-codec" branch. >> > The classes to look at >> > Flow.java in the o/a/q/p/transport2 package >> > TransportTypesEncoder and TransportTypesDecoder in o/a/q/p/codec2 >> package. >> > >> > I've also put some question marks in the code .. pls answer them. >> > But more importantly pls provide feedback on the direction taken. >> > >> > I'm keen to settle down on the direction/approach first and then will >> start >> > implementing the rest. >> > >> >> It looks like a good start from what I saw from the commit message that >> flew through my inbox. One general question, are you intending to develop >> the rest of the performatives by hand, or is this just a skeleton to >> figure >> out what your generated output should look like, or is that TBD? >> > > At this point I'm undecided. I will write a few more Performatives by hand > and then figure out if it can be automated. > It's not a lot of classes either .. so writing them by hand might not be a > huge issue. > > >> >> If you put it up on reviewboard or make a PR or something I can make some >> more detailed line by line comments and answer the questions you embedded >> in the code. >> > > https://reviews.apache.org/r/30379/ > > Thanks in advance for your comments/feedback. > > >> >> --Rafael >> > >
