On Tue, 2015-02-17 at 10:38 +0000, Gordon Sim wrote:
> On 02/16/2015 09:58 PM, Alan Conway wrote:
> > This checkin:
> >
> > 6136f11 make container a subclass of reactor and remove redundant code
> > which is replaced by reactor
> >
> > severely broke the dispatch system tests. I haven't looked into it yet
> > but my best guess is they broker the SyncRequestResponse class that is
> > used by the dispatch tools and hence by most of those tests.
> >
> > I will investigate, if anybody else sees anything please let me know.
> > Apart from fixing the issue we need to improve the tests for that class
> > in the proton build (that would be my fault.)
> 
> There is one test for SyncRequestResponse, which was passing when the 
> commit was made. There are also a couple of examples using 
> BlockingConnection on which it depends, which were also working fine.
> 
> However the change above is a major one, the entire internal plumbing of 
> the container being replaced by the c reactor, so it is certainly quite 
> possible that there are some bugs.

The memory errors I reported have been going on since before that commit
so it may just be a coincidence that the problems showed  up at that
point.



Reply via email to