[
https://issues.apache.org/jira/browse/PROTON-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327444#comment-14327444
]
Alan Conway commented on PROTON-823:
------------------------------------
I would suggest re-instating the central check on trace flags that was removed
by:
bc91eb6 Revert "PROTON-772: Remove all direct printing to stdout and stderr
(missed one)" This reverts commit a0e7cced9d9840c7a81185e83a6371ef5fbc96ca.
diff --git a/proton-c/src/transport/transport.c
b/proton-c/src/transport/transport.c
index 1a7ec69..0cc4697 100644
--- a/proton-c/src/transport/transport.c
+++ b/proton-c/src/transport/transport.c
@@ -2422,8 +2422,7 @@ pn_record_t *pn_transport_attachments(pn_transport_t
*transport)
void pn_transport_log(pn_transport_t *transport, const char *message)
{
assert(transport);
- if (transport->trace)
- transport->tracer(transport, message);
+ transport->tracer(transport, message);
}
void pn_transport_vlogf(pn_transport_t *transport, const char *fmt, va_list ap)
> Proton prints some log/trace information to stdout/stderr.
> ----------------------------------------------------------
>
> Key: PROTON-823
> URL: https://issues.apache.org/jira/browse/PROTON-823
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: 0.9
> Reporter: Alan Conway
> Assignee: Andrew Stitcher
> Fix For: 0.9
>
>
> > Latest proton trunk seems to be dumping these to stdout or stderr, this
> > is from a proton reatactor based python client:
> >
> > [0x10d4a60]:error:140940E5:SSL routines:SSL3_READ_BYTES:ssl handshake
> > failure
> >
> > Not sure where its coming from, thought you might know...
> from openssl.c in one of the ssl_log_...
> functions - They don't all seem to check for trace flags
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
