[ 
https://issues.apache.org/jira/browse/PROTON-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497717#comment-14497717
 ] 

ASF GitHub Bot commented on PROTON-334:
---------------------------------------

Github user dnwe commented on the pull request:

    https://github.com/apache/qpid-proton/pull/17#issuecomment-93675959
  
    @astitcher minor issue, unrelated to the feature itself, but the CMake 
build doesn't currently report which sasl implementation is being used. I just 
see:
    ```
    -- Looking for sasl_checkpass in sasl2
    -- Looking for sasl_checkpass in sasl2 - found
    -- Looking for include file sasl/sasl.h
    -- Looking for include file sasl/sasl.h - found
    -- Found SASL: 1  
    ```
    Could you perhaps add something along the lines of:
    ```
    if (FOUND_SASL_LIB)
      message(STATUS "Found SASL: ${FOUND_SASL_LIB}")
    else()
      message(STATUS "Found SASL: BUILT-IN")
    endif(FOUND_SASL_LIB)
    ```
      



> SASL Implementation for Proton C
> --------------------------------
>
>                 Key: PROTON-334
>                 URL: https://issues.apache.org/jira/browse/PROTON-334
>             Project: Qpid Proton
>          Issue Type: Wish
>          Components: proton-c
>            Reporter: Ted Ross
>            Assignee: Andrew Stitcher
>
> It would be desirable to have the ability to use a plug-in module for SASL in 
> Proton.  The following implementations could then be developed:
> 1) A portable stand-alone plugin that does ANONYMOUS, PLAIN, and EXTERNAL
> 2) A Cyrus-Sasl based plugin for Linux
> 3) A Windows plugin



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to