Github user rhs commented on the pull request:
https://github.com/apache/qpid-proton/pull/21#issuecomment-94755563
+1 from me
Initially I thought this wouldn't account for detach properly, but looking
at the code I managed to convince myself that it will. If you have time,
however, it would be nice to augment/add a test of the detach scenario.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
