Robbie Gemmell commented on PROTON-885:

As such, the patch probably needs to be a bit more explicit about where they 
came from, and if they were merged in then wouldn't the overall qpid-proton 
source package also need to include a copy of 
https://github.com/zeromq/pyzmq/blob/master/COPYING.BSD somewhere?

The LICENCE file at the root would need to reflect the licence of included 
files, either by containing the appropriate licence text, or a pointer to it in 
the tree.

The main issue I see here is actually what licence the files are under. At the 
moment it seems some of then have the 'ASF variant' of the ALv2 in their header 
*AND* reference that they were based on the BSD licensed PyZMQ, which doesnt 
seem quite right to me. It would probably be better to just attribute that the 
files were adapted from PyZMQ, leave them BSD licensed, and then point them out 
as such in our LICENCE file with the licence details. Alternatively, write a 
new set of ALv2 licenced changes from scratch. Alternatively still, ask the 
PyZMQ writers to re-licence the bits of interest .

> Allow setup.py to bundle qpid-proton
> ------------------------------------
>                 Key: PROTON-885
>                 URL: https://issues.apache.org/jira/browse/PROTON-885
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: python-binding
>            Reporter: Flavio Percoco
>            Assignee: Ken Giusti
>         Attachments: 0001-Allow-setup.py-for-bundling-proton.patch
>     Allow setup.py for bundling proton
>     As of now, it's not possible to install python-qpid-proton if
>     libqpid-proton is not present in the system. To be more precises, it's
>     possible to build python-qpid-proton using cmake, upload it and beg to
>     the gods of OPs that the required (and correct) shared library will be
>     present in the system.
>     This patch adds to python-qpid-proton the ability to download, build and
>     install qpid-proton if the required version is not present in the
>     system. It does this by checking - using pkg-config - whether the
>     required version is installed and if not, it goes to downloading the
>     package from the official apache source and builds it using cmake.
>     As nasty as it sounds, this process is not strange in the Python
>     community. Very famous - and way more used - libraries like PyZMQ (from
>     which this work took lots of inspiration) do this already in a fairly
>     more complex way.
>     This first step is quite simple, it checks, downloads and builds using
>     the standard tools. It's enabled just for linux and it does not use
>     fancy flags. Future enhancements could take care of improving the
>     implementation and extending it to support other systems.

This message was sent by Atlassian JIRA

Reply via email to