ASF subversion and git services commented on PROTON-883:

Commit e349a02120d306babb0219238f172c26cc8b49ea in qpid-proton's branch 
refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=e349a02 ]

PROTON-883: Fixed using a pointer value as a size
- It's not clear to me how the warning message this caused went ignored
- It's also not clear to me why this error passed the tests without
  crashing, probably the ruby tests need improving.

> Return the raw bytes from a transport buffer in Ruby.
> -----------------------------------------------------
>                 Key: PROTON-883
>                 URL: https://issues.apache.org/jira/browse/PROTON-883
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: ruby-binding
>            Reporter: Darryl L. Pierce
>            Assignee: Darryl L. Pierce
>             Fix For: 0.9.1
>         Attachments: 0001-PROTON-883-Wrap-pn_transport_peek-for-Ruby.patch
> When retrieving a message that contains raw bytes rather than strings, the 
> Swig bindings can return a truncated string. This is due to the method 
> SWIG_FromCharPtr stopping at the first 0 byte since it's treating the content 
> as a C string and not as an array of bytes.
> The code should, instead, using something like SWIG_FromCharPtrAndSize to 
> return the full content and not guess at the length based on null bytes.

This message was sent by Atlassian JIRA

Reply via email to