Github user astitcher commented on the pull request:
https://github.com/apache/qpid-proton/pull/35#issuecomment-109423155
There are a number of places in the API where the API has something like:
`void setXXX(const char* bytes, size_t size);` this isn't very C++ like -
in fact it adds very little value over the original API whilst still adding an
extra layer wrapping it. If we are going to add a wrapper like this we should
be making it more C++ like either using `void XXXX(const std::string&);` or
`void XXXX(const std::vector<char>&);` (one or other or both depending on the
context).
This is equally true for getters as setters, although for these we might
need to create some wrapping types to avoid copying if the value returned is a
pointer into an existing value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
