Robbie Gemmell commented on PROTON-915:

I'd agree that you could possibly argue whether the spec doesnt strictly 
forbids you sending any more bytes, but I do think it is the intention and 
would say we should not. If it was for example the non-SASL AMQP header that 
was received and 'not supported' because we were requiring a SASL layer first, 
then it would certainly seem incorrect to me send anything beyond the SASL 
header back. Incidentally, we should probably cover that case with tests too.

For proton-j at least, the sending of the open and close frames could be 
related or even the same underlying issue as another I raised recently, 

> Incompatible protocol header handled incorrectly
> ------------------------------------------------
>                 Key: PROTON-915
>                 URL: https://issues.apache.org/jira/browse/PROTON-915
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.9, 0.9.1
>            Reporter: Gordon Sim
>            Assignee: Rafael H. Schloming
>            Priority: Blocker
>             Fix For: 0.10
>         Attachments: 
> 0001-PROTON-915-Send-correct-AMQP-header-upon-protocol-mi.patch
> The correct response is to send back a supported header[1] before closing the 
> socket. This worked for 0.8 but is broker from 0.9 onwards, I believe by this 
> commit: 
> https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;a=commit;h=1b2be03c748ef5a57cf181f8373b9b6e8f8cfd22
> It means anything relying on proton-c for protocol header handling is not 
> compliant with the spec.
> [1]  section 2.2 of spec: "If the requested protocol version is not 
> supported, the server MUST send a protocol header with a supported protocol 
> version and then close the socket." 

This message was sent by Atlassian JIRA

Reply via email to