[
https://issues.apache.org/jira/browse/PROTON-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598095#comment-14598095
]
michael goulish commented on PROTON-919:
----------------------------------------
~~~ NOTE ~~~
The proposed change alters the public API in that it changes
pn_transport_set_channel_max() to return an int, rather than void.
> make C impl behave like java wrt channel_max error
> --------------------------------------------------
>
> Key: PROTON-919
> URL: https://issues.apache.org/jira/browse/PROTON-919
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c, python-binding
> Reporter: michael goulish
> Assignee: michael goulish
> Priority: Minor
>
> In the Java impl, I made TransportImpl throw an exception if the application
> tries to change the local channel_max setting after we have already sent the
> OPEN frame to the remote peer. ( Because at that point we communicate our
> channel_max limit to the peer -- no fair changing it afterwards.)
> One reviewer suggested that it would be nice if the C impl worked the same
> way. That would mean that pn_set_channel_max() would have to return a result
> code, which the Python binding would detect -- Python binding throws
> exception, python tests detect it -- so it would work same way as Java.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
