On 6 July 2015 at 16:51, Andrew Stitcher <astitc...@redhat.com> wrote: > On Mon, 2015-07-06 at 11:30 -0400, Rafael Schloming wrote: >> I wired in allowSkip in a very minimal way just to restore the ability to >> force the old behaviour. It would be a fairly trivial to change the name of >> course, > > I'm not sure if that really applies as the method is on a different > object now (transport instead of SASL). > >> however it appears there are a bunch of other related changes that >> go along with it, e.g. adding a bunch of accessors and fixing the error >> behavior. Currently if you put in require authentication the java sasl >> layer will simply die with a TransportException if it sees a regular AMQP >> header, and the tests appear to expect something more graceful. > > Yes you will need the isAuthenticated property. >
The old toggle only used to define whether sasl was required or not (which it historically was once you enabled the sasl layer, and the toggle was never implemented in proton-j), whereas IIRC the new 'requireAuth' governs that but also whether ANONYMOUS is allowed or not when a SASL layer is used, is that correct? Given the older SASL API means much of the SASL work including mechansim selection happens outside/before proton-j and you get as far as making a connection, isnt that going to be a bit of a pain to implement and use? Might it be simpler to use allowSkip() until such time the wider SASL API is actually implemented, keep the default behaviour as it was previously (so people will be less likely to need to use the behaviour toggle and less likely to care what it is called), and update whichever reactor tests that needed the change to configure it that way in the meantime? > Hmm, not sure about that, I think the tests just ensure that > authenticated is not true, although I suppose they do rely on not > getting an exception, that may be incidental behaviour though. > > The new APIs aren't very extensive, and should be fairly extensively > documented at https://cwiki.apache.org/confluence/x/B5cWAw > (this should be up to date). > > Bringing Proton-J in line with the new SASL APIs is > https://issues.apache.org/jira/browse/PROTON-910 > > Andrew > >
