Andrew Stitcher commented on PROTON-961:

Is there a test for large messages? I'm guessing there is not otherwise it 
would fail.

If this is so then this change would be fixing an issue (just not one that 
currently has a test).

So I'd strongly suggest adding a new test that fails if you check this change 

One of the major purposes of the the tests is to ensure changes do not regress, 
so if the tests still pass after a change then you should be able to assume 
that the change is good.

Of course the flip side of this is that we need to add failing tests for all 
the bugs we fix too (as in failing before the fixing change), else we don't get 
to find regressions.

> messenger doesn't handle multi-frame transfers
> ----------------------------------------------
>                 Key: PROTON-961
>                 URL: https://issues.apache.org/jira/browse/PROTON-961
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.10, 0.11
>            Reporter: Gordon Sim
> See QPID-6651 for a reproducer.

This message was sent by Atlassian JIRA

Reply via email to