ASF subversion and git services commented on PROTON-905:

Commit 0fa93bcbc0b5cb2988254eadf1bbd8a7f62f87eb in qpid-proton's branch 
refs/heads/master from [~kgiusti]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=0fa93bc ]

PROTON-905: Revert "PROTON-905: fix leak of session/links when not using events"

This reverts commit 653f4e5fe2b9307dccced0a5a85028d1ca67c66a.

This patch causes crashes in qpidd when running its HA tests.

> Long-lived connections leak sessions and links
> ----------------------------------------------
>                 Key: PROTON-905
>                 URL: https://issues.apache.org/jira/browse/PROTON-905
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.9.1
>            Reporter: Ken Giusti
>            Assignee: Rafael H. Schloming
>            Priority: Critical
>             Fix For: 0.10
>         Attachments: test-send.py
> I found this issue while debugging a crash dump of qpidd.
> Long lived connections do not free its sessions/link.
> This only applies when NOT using the event model.  The version of qpidd I 
> tested against (0.30) still uses the iterative model.  Point to consider, I 
> don't know why this is the case.
> Details:  I have a test script that opens a single connection, then 
> continually creates sessions/links over that connection, sending one message 
> before closing and freeing the sessions/links.  See attached.
> Over time the qpidd run time consumes all memory on the system and is killed 
> by OOM.  To be clear, I'm using drain to remove all sent messages - there is 
> no message build up.
> On debugging this, I'm finding thousands of session objects on the 
> connections free sessions weakref list.  Every one of those sessions has a 
> refcount of one.
> Once the connection is finalized, all session objects are freed.  But until 
> then, freed sessions continue to accumulate indefinitely.

This message was sent by Atlassian JIRA

Reply via email to