[
https://issues.apache.org/jira/browse/PROTON-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653518#comment-14653518
]
ASF GitHub Bot commented on PROTON-964:
---------------------------------------
Github user bozzzzo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36180258
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
@@ -68,12 +69,19 @@ void clear()
}
@Override
- public Type getType()
+ public EventType getEventType()
{
return type;
}
@Override
+ public Type getType() {
+ if (type instanceof Type)
--- End diff --
Why this needs to be so is more obvious if you consider how Core events
(maybe they should be Engine events) would look if reactor had the
ReallyReallyCore events :)
Wdyt, replace Core with Engine in all above comments and leave Core for the
deeper refactoring.
> Proton-J extensible event types
> -------------------------------
>
> Key: PROTON-964
> URL: https://issues.apache.org/jira/browse/PROTON-964
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-j
> Affects Versions: 0.10
> Reporter: Bozo Dragojevic
> Assignee: Bozo Dragojevic
> Fix For: 0.11
>
>
> Event.Type is an enum which makes it impossible to extend.
> Introduce a separate interface EventType and make Event.Type implement it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
